> On Oct. 14, 2016, 8:58 p.m., Aleix Pol Gonzalez wrote: > > src/engine/transaction.cpp, line 457 > > <https://git.reviewboard.kde.org/r/129182/diff/1/?file=482195#file482195line457> > > > > add const
The question here is - why create a temporary QList here at all - I'm now using Q_FOREACH on the map directly - Christian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129182/#review100007 ----------------------------------------------------------- On Oct. 14, 2016, 9:11 p.m., Christian Ehrlicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129182/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2016, 9:11 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > While trying to figure out why indexing my files is so slow, I compiled baloo > on my system with clazy and found some unnecessary copies in foreach loops. > It's not related to my problem and not really a performance critical part but > imo should be fixed anyway > > > Diffs > ----- > > src/engine/transaction.cpp 908a81f > src/file/fileindexerconfig.cpp ccb5d80 > src/file/pendingfilequeue.cpp 489f100 > tests/file/storagedevicestest.cpp f269c81 > > Diff: https://git.reviewboard.kde.org/r/129182/diff/ > > > Testing > ------- > > Compiles fine > > > Thanks, > > Christian Ehrlicher > >
