----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129182/ -----------------------------------------------------------
(Updated Oct. 15, 2016, 11:16 a.m.) Status ------ This change has been marked as submitted. Review request for Baloo. Changes ------- Submitted with commit e6bd357153a790ef66dc803cd3451270e9311134 by Christian Ehrlicher to branch master. Repository: baloo Description ------- While trying to figure out why indexing my files is so slow, I compiled baloo on my system with clazy and found some unnecessary copies in foreach loops. It's not related to my problem and not really a performance critical part but imo should be fixed anyway Diffs ----- src/engine/transaction.cpp 908a81f src/file/fileindexerconfig.cpp ccb5d80 src/file/pendingfilequeue.cpp 489f100 tests/file/storagedevicestest.cpp f269c81 Diff: https://git.reviewboard.kde.org/r/129182/diff/ Testing ------- Compiles fine Thanks, Christian Ehrlicher