On 28 February 2018 at 11:10, David Rosca <now...@gmail.com> wrote: > Hi, > I'd like to request review for Falkon.
Looks good to me. I tidied up licencing and appstream bits. There's some MPL-1.1 licenced files in the themes but I guess that's fine. I'd query why Python plugins are done with PySide, I'm not sure how well maintained that is and there's no packages for Debian/Ubuntu distros of PySide2 as far as I know. Your release announcement needs to have the full fingerprint that the tar is signed with. The incubator process seems to have stalled. Christoph can you get this moving again? https://community.kde.org/Incubator/Projects/Falkon There's no documentation but I'm not sure anyone cares about that any more, I'm fine without it. As a user I'd suggest getting rid of the default bookmarks, I don't have much need to visit Falkon git repo. Yay for decent web browser back in KDE! Jonathan
