ahmadsamir marked 7 inline comments as done.
ahmadsamir added a comment.

  In D12015#241801 <https://phabricator.kde.org/D12015#241801>, @ltoscano wrote:
  
  > The doc team was automatically added as subscriber.
  >  Regarding the entity, just expand it inline, or define the entity in this 
file: we add it for people who have more contributions (and it would introduce 
a dependency on a new version of Frameworks, so you would need to keep the 
expanded version here anyway).
  
  
  OK, thanks for the pointers.
  
  @yurchor: thanks for the review.

INLINE COMMENTS

> yurchor wrote in index.docbook:1332
> Would it be better to have multiple sect1s (sect2s -> sect1s) in a chapter 
> rather than have just one?

Actually I want all the content to be in one page, since it's all relevant and 
the user would have to keep going back and forth between multiple files to look 
stuff up.

> yurchor wrote in index.docbook:1341
> going -> go

I am not a native speaker, but "going" sounds (more) correct to me.

I would use "go" like this:
To open the Key Bindings Editor "click" the menu entry ........, and "go" to 
the keyboard tab.

> yurchor wrote in index.docbook:1363
> Ctrl keys _are_ not pressed.

It was supposed to be "key", I've fixed that.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D12015

To: ahmadsamir, #konsole, hindenburg, yurchor
Cc: ltoscano, kde-doc-english, hindenburg, #konsole, herrold, ngraham

Reply via email to