----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110351/#review32220 -----------------------------------------------------------
kdeui/fonts/kfontrequester.cpp <http://git.reviewboard.kde.org/r/110351/#comment23973> Should be fine in practice, but probably a good idea to initialize this bool to false. kdeui/fonts/kfontrequester.cpp <http://git.reviewboard.kde.org/r/110351/#comment23972> ok is a bool, QDialog::Accepted not. This if looks wrong. Should be changed to simply if(ok) staging/kde4support/src/kdeui/kfontdialog.h <http://git.reviewboard.kde.org/r/110351/#comment23974> Should be changed to kde4support_export.h staging/kde4support/src/kdeui/kfontdialog.h <http://git.reviewboard.kde.org/r/110351/#comment23975> Should be changed to KDE4SUPPORT_EXPORT. - Kevin Ottens On May 7, 2013, 7:41 p.m., Anne-Marie Mahfouf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110351/ > ----------------------------------------------------------- > > (Updated May 7, 2013, 7:41 p.m.) > > > Review request for KDE Frameworks, David Faure and Kevin Ottens. > > > Description > ------- > > Move KFontDialog to KDE4Support, move test as well, thing to check is diff > for kdeui/fonts/kfontrequester.cpp to see if I got it right. > > > Diffs > ----- > > kdeui/CMakeLists.txt 38a7238 > kdeui/fonts/kfontdialog.h 9098a83 > kdeui/fonts/kfontdialog.cpp 8632183 > kdeui/fonts/kfontrequester.cpp 09aaa45 > kdeui/tests/CMakeLists.txt 037cec1 > kdeui/tests/kfontdialogtest.cpp cbccadc > staging/kde4support/src/CMakeLists.txt f5fbe60 > staging/kde4support/src/kdeui/kfontdialog.h PRE-CREATION > staging/kde4support/src/kdeui/kfontdialog.cpp PRE-CREATION > staging/kde4support/tests/CMakeLists.txt 3d6a6dd > staging/kde4support/tests/kfontdialogtest.cpp PRE-CREATION > tier1/kwidgetsaddons/src/kfontchooser.h 8bdd5d4 > > Diff: http://git.reviewboard.kde.org/r/110351/diff/ > > > Testing > ------- > > It builds. > > > Thanks, > > Anne-Marie Mahfouf > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel