----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110351/#review32423 -----------------------------------------------------------
Ship it! I'm slightly confused by r2 and r3 of this patch being in fact two different patches. :-) Anyway each of them looks fine, so a "ship it" from me. If you can indeed keep them as separate patches when you push, it's indeed a good idea to do the "port away" and the "class move" in separate commits. - Kevin Ottens On May 8, 2013, 11:46 a.m., Anne-Marie Mahfouf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110351/ > ----------------------------------------------------------- > > (Updated May 8, 2013, 11:46 a.m.) > > > Review request for KDE Frameworks, David Faure and Kevin Ottens. > > > Description > ------- > > Move KFontDialog to KDE4Support, move test as well, thing to check is diff > for kdeui/fonts/kfontrequester.cpp to see if I got it right. > > > Diffs > ----- > > kdeui/CMakeLists.txt 38a7238 > kdeui/fonts/kfontdialog.h 9098a83 > kdeui/fonts/kfontdialog.cpp 8632183 > kdeui/tests/CMakeLists.txt 037cec1 > kdeui/tests/kfontdialogtest.cpp cbccadc > staging/kde4support/src/CMakeLists.txt f5fbe60 > staging/kde4support/src/kdeui/kfontdialog.h PRE-CREATION > staging/kde4support/src/kdeui/kfontdialog.cpp PRE-CREATION > staging/kde4support/tests/CMakeLists.txt 3d6a6dd > staging/kde4support/tests/kfontdialogtest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110351/diff/ > > > Testing > ------- > > It builds. > > > Thanks, > > Anne-Marie Mahfouf > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel