----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112560/ -----------------------------------------------------------
(Updated Sept. 10, 2013, 5:50 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks. Description ------- Drop KNotifications dependency from KCompletion. Reasons: - Its not used in KDE4 - It creates noise - It bumps KCompletion from tier2 to tier3 I know I already sent an e-mail about it, but it seemed to me that a review request would be more welcome. Diffs ----- staging/kcompletion/src/CMakeLists.txt 1300ab5 staging/kcompletion/src/kcompletion.h 682a058 staging/kcompletion/src/kcompletion.cpp bcd220a staging/kcompletion/src/khistorycombobox.cpp fe955a2 Diff: http://git.reviewboard.kde.org/r/112560/diff/ Testing ------- builds, tests pass. Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
