----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112560/#review39748 -----------------------------------------------------------
This review has been submitted with commit 61f7afdc7ab7d14f135967dfdd0c4a2b86d7fe6b by Aleix Pol to branch frameworks. - Commit Hook On Sept. 9, 2013, 3:50 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112560/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2013, 3:50 p.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Drop KNotifications dependency from KCompletion. > > Reasons: > - Its not used in KDE4 > - It creates noise > - It bumps KCompletion from tier2 to tier3 > > I know I already sent an e-mail about it, but it seemed to me that a review > request would be more welcome. > > > Diffs > ----- > > staging/kcompletion/src/CMakeLists.txt 1300ab5 > staging/kcompletion/src/kcompletion.h 682a058 > staging/kcompletion/src/kcompletion.cpp bcd220a > staging/kcompletion/src/khistorycombobox.cpp fe955a2 > > Diff: http://git.reviewboard.kde.org/r/112560/diff/ > > > Testing > ------- > > builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
