On Fri, Sep 13, 2013 at 1:17 PM, David Faure <fa...@kde.org> wrote: > On Friday 13 September 2013 13:03:29 Aleix Pol wrote: > > On Fri, Sep 13, 2013 at 9:43 AM, David Faure <fa...@kde.org> wrote: > > > On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: > > > > I'd say that all Qt dependencies in the module should be defined only > > > > > > once > > > > > > > in the root CMakeLists.txt. Actually this should be the only file > with > > > > "find_package" calls. > > > > > > And I disagree. If you build the framework with unittests disabled > (like > > > distros will probably do) then there's no point in searching for > QtTest. > > > Modularity wins again, better do that inside the autotests subdir. > > > > > > Apart from QtTest, I agree, though. > > > > > > -- > > > David Faure, fa...@kde.org, http://www.davidfaure.fr > > > Working on KDE, in particular KDE Frameworks 5 > > > > Well, then let's make this a especial case for autotests/ and tests/. We > > shouldn't have any find_package() within src/, and that's the case in > many > > places. > > Not tests/. That's for manual tests, no qtestlib there. > > -- > David Faure, fa...@kde.org, http://www.davidfaure.fr > Working on KDE, in particular KDE Frameworks 5 > > Well, but in that case you'll maybe want to find QtGui, QtWidgets or KF5::AwesomeTests.
Aleix
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel