> On Sept. 23, 2013, 10:27 a.m., Kevin Ottens wrote: > > Not that I'm really qualified with xcb code, but it looks ok to me. > > Martin Gräßlin wrote: > no, no. The issues mentioned by Fredrik should be fixed. > > Fredrik Höglund wrote: > Kevin, please don't take this the wrong way, but it would be enormously > helpful if you didn't approve patches > you yourself claim to NOT be qualified to review, when others who ARE > qualified have already reviewed them and > voiced concerns. > > This is not the first time you have done this either. >
Yeah, that's one of the things I don't like with reviewboard... I've no way to vote that properly (I'm kind of used to the +1 vs +2 distinction in gerrit). There's more than one aspect to a patch, so although I'm not qualified for the XCB specific code I looked at the other aspects. That's why I put a ship it, but adding the comment so that others with know how look at it... I looks heavy handed in reviewboard lingo indeed. Hm, I guess with reviewboard I should simply post a comment in those cases. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/#review40515 ----------------------------------------------------------- On Sept. 17, 2013, 5:42 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112755/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2013, 5:42 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Implements the createPixmapFromHandle by getting the image for the pixmaps > and using it as either the Pixmap or the bitmap mask. > > > Diffs > ----- > > tier1/kwindowsystem/src/kxutils.cpp 33bd678 > tier1/kwindowsystem/src/kxutils_p.h 84d639b > > Diff: http://git.reviewboard.kde.org/r/112755/diff/ > > > Testing > ------- > > Adjusted KWin to take this codepath and say thanks to Iceweasel for having a > mask > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel