----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/#review42568 -----------------------------------------------------------
Looks much better, but it doesn't handle depth 30 pixmaps. tier1/kwindowsystem/src/kxutils.cpp <http://git.reviewboard.kde.org/r/112755/#comment30869> static tier1/kwindowsystem/src/kxutils.cpp <http://git.reviewboard.kde.org/r/112755/#comment30870> static tier1/kwindowsystem/src/kxutils.cpp <http://git.reviewboard.kde.org/r/112755/#comment30871> What if the host byte order is not little endian? - Fredrik Höglund On Oct. 24, 2013, 10:22 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112755/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2013, 10:22 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Implements the createPixmapFromHandle by getting the image for the pixmaps > and using it as either the Pixmap or the bitmap mask. > > > Diffs > ----- > > tier1/kwindowsystem/src/kxutils.cpp 33bd678 > tier1/kwindowsystem/src/kxutils_p.h 84d639b > tier1/kwindowsystem/tests/CMakeLists.txt 5cf5868 > tier1/kwindowsystem/tests/createpixmapfromhandletest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112755/diff/ > > > Testing > ------- > > Adjusted KWin to take this codepath and say thanks to Iceweasel for having a > mask > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
