davidre added inline comments.

INLINE COMMENTS

> kcolorschememanager.cpp:220
> +{
> +    return createSchemeSelectionMenu(QIcon(),QString(), QString(), parent);
> +}

Should we also do this for the other overloads? Or would that behavior change 
be a blocker? ALso an application would want to call 
`KColorSchemeManager::createSchemeSelectionMenu(const QString 
&selectedSchemeName, QObject *parent)` probably if the custom scheme is saved 
between launches.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: ahmadsamir, asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

Reply via email to