asemke added inline comments. INLINE COMMENTS
> davidre wrote in kcolorschememanager.cpp:220 > Should we also do this for the other overloads? Or would that behavior change > be a blocker? ALso an application would want to call > `KColorSchemeManager::createSchemeSelectionMenu(const QString > &selectedSchemeName, QObject *parent)` probably if the custom scheme is saved > between launches. I'm not the author of this code but I don't see why this should be a blocker. With this you wouldn't break anything and would simply add more consistency across different applications. REPOSITORY R265 KConfigWidgets BRANCH systemthem (branched from master) REVISION DETAIL https://phabricator.kde.org/D25877 To: davidre, #frameworks, ngraham Cc: ahmadsamir, asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
