ahmadsamir added inline comments.
INLINE COMMENTS
> ksortfilterproxymodel.cpp:101
> +{
> + return QSortFilterProxyModel::filterRegExp().pattern();
> +}
In setFilterRegExp(),
QSortFilterProxyModel::setFilterRegularExpression(QRegularExpression &) is
used, so IIUC here it should be :
QSortFilterProxyModel::filterRegularExpression().pattern()
> ksortfilterproxymodel.h:103
> +
> + void setFilterRegExp(const QString &exp);
> + QString filterRegExp() const;
Hello. Since you're using QRegularExpression, maybe rename to setFilterRegex()
or setFitlerRegularExpression() (the latter matches QSortFilterProxyModel
naming schema) to avoid QRegExp vs QRegularExpression confusion?
(Another pro for renaming setFilterRegExp() to setFilterRegularExpression()).
REPOSITORY
R275 KItemModels
REVISION DETAIL
https://phabricator.kde.org/D25326
To: davidedmundson
Cc: ahmadsamir, broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n,
GB_2, michaelh, ngraham, bruns
