davidedmundson added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in ksortfilterproxymodel.cpp:101
> In setFilterRegExp(), 
> QSortFilterProxyModel::setFilterRegularExpression(QRegularExpression &) is 
> used, so IIUC here it should be :
> QSortFilterProxyModel::filterRegularExpression().pattern()

I'm not sure your comments are still valid, we switched to using the superclass 
QSortFilterProxyModel's methods, and don't shadow that part here.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25326

To: davidedmundson
Cc: ahmadsamir, broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

Reply via email to