broulik added inline comments.
INLINE COMMENTS
> kpropertiesdialog.cpp:1114
> +
> d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(service->icon()));
> + connect(d->m_sizeDetailsButton, &QPushButton::clicked, this,
> [this, service]() {
> + KRun::runApplication(*service, { properties->url() },
> properties->window());});
Not sure copying that pointer into the lambda is a good idea?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26650
To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
