anthonyfieroni added inline comments. INLINE COMMENTS
> meven wrote in kpropertiesdialog.cpp:1114 > service is a QExplicitlySharedDataPointer<KService> in fact, I guess it > covers lambda use cases. OK, it can be a problem since we can have many objects of KFilePropsPlugin thus lambda will extend service ptr life to the process end, which can result in memory leak (it's not leak) But since it's a plugin we don't expect a tons of objects, but i'm fine to make service a class scope var to not outlive the plugin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: shubham, broulik, ngraham Cc: meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
