meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.
Nice one. Good step splitting out this.
INLINE COMMENTS
> filesystem_entry.cpp:47
> +
> +QString FilesystemEntry::type() const
> +{
It would be great to expose an enum (KIO's KFileSystemType does this a little).
But given the number of filesystems this days, it may be overcomplicated.
> filesystem_entry.h:88
> + */
> + //int m_dumpFrequency;
> + /*
Is it necessary to keep if it is commented out ?
> filesystem_entry.h:94
> + */
> + //int m_passNo;
> +};
Same
REPOSITORY
R245 Solid
BRANCH
introduce_filesystem_entry
REVISION DETAIL
https://phabricator.kde.org/D27152
To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
