hallas added inline comments. INLINE COMMENTS
> meven wrote in filesystem_entry.cpp:47 > This sound sane to me. > Ideally we would store only the string in case of an unknown fs or the enum > but not both for a same entry, the choice could be done in ctor. I have added a new enum class type `FilesystemType` to represent the known filesystem types. Currently I have just added a single known filesystem type, but this should be extended over time. I have also added the necessary from/to string conversion functions. > bruns wrote in filesystem_entry.h:34 > wrap long lines, also below. I have wrapped all lines to fit 80 characters in width > bruns wrote in filesystem_entry.h:48 > Whats wrong with mountPoint? Its used everywhere else here, and is a well > known term. Good point :) Actually, I don't know why I called the function `mountPath` instead of `mountPoint` - but I have reamed it, along with the member etc. > bruns wrote in fstabhandling.cpp:259 > detaches m_fstabCache, also below. The code didn't need the for loop anyway, so I have rewritten it > meven wrote in fstabhandling.cpp:388 > Detaches m_mtabCache, just qAsConst or temporary const variable The code didn't need the for loop anyway, so I have rewritten it REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27152 To: hallas, #frameworks, bruns, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
