dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
Well, I'm not the KConfig maintainer, mdawson is :-) INLINE COMMENTS > kcoreconfigskeleton.h:89 > + */ > + void setGroup(const KConfigGroup &cg); > + Missing @since 5.68 > kcoreconfigskeleton.h:96 > + * @sa setGroup(KConfigGroup cg) > + */ > + KConfigGroup configGroup(KConfig *config) const; Missing @since 5.68 > kcoreconfigskeleton.h:448 > void swapDefault() override; > // shadow the method in KConfigSkeletonItem, which should be fine for > autogenerated code > // KF6 TODO - fix this So this KF6 TODO is to make those methods virtual? It's a bit unclear to me... I'm asking because: if the solution is something else then maybe it can be done already for those new methods. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns