bport added inline comments. INLINE COMMENTS
> KConfigXmlParser.cpp:203 > } > + else if (choice.name.contains(QLatin1Char(' '))) { > + std::cerr << "Tag <choice> attribute 'name' cannot contain a > space. You can use attribute 'value' to pass any string as the choice value." > << std::endl; Can we do a test on more than ' ' value, proably solve other case. And we probably want to limit what is a correct value, any string seems a bit too large, some character can be problematic when we write back to config file. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns