meven added inline comments.

INLINE COMMENTS

> bport wrote in KConfigXmlParser.cpp:203
> Can we do a test on more than '  ' value, proably solve other case.
> And we probably want to limit what is a correct value, any string seems a bit 
> too large, some character can be problematic when we write back to config 
> file.

If you don't mind I am putting aside the second part as it is not directly 
related to this PR, i.e name attribute validation. (FYI we had 
KConfigXmlParser::validateNameAndKey)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27463

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

Reply via email to