meven added a comment.
In D23926#538778 <https://phabricator.kde.org/D23926#538778>, @mthw wrote: > > 3. Instead of unconditionally doing `q->insertPluginAt(plugin, 1);`, you'd want to do something more like this: > > > > > > > > if (plugin == "details" /* this is pseudocode */) { > > q->insertPluginAt(plugin, 1); > > } else { > > q->insertPlugin(plugin); > > } > > > > > > I'm actually not sure how to check for what the plugin is though. Maybe someone from #frameworks <https://phabricator.kde.org/tag/frameworks/> can help. > > This is mostly done but we still need to do this the check, but neither me nor @ngraham know how to do it. An alternative would be to move the whole block inserting KPropertiesDialog/Plugin before "KChecksumsPlugin". AFAIK there are only two KPropertiesDialog/Plugin, so this would move details and baloo both of before the rest, which is fine IMO. You would not need an integer parameter to `insertPluginAt` anymore. INLINE COMMENTS > kpropertiesdialog.cpp:586 > > + > if (KFilePermissionsPropsPlugin::supports(m_items)) { Not needed, if you could remove REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun, ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender