ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
For future reference, you can rebase like so:
git fetch
git rebase origin/master
Also please make sure your code at least compiles before submitting a patch
or a change to an existing patch.
INLINE COMMENTS
> kpropertiesdialog.cpp:645
> +
> + if (ptr->serviceId() ==
> QStringLitteral("baloofilepropertiesplugin")) {
> + q->insertPluginAt(plugin, 1);
/home/nate/kde/src/kio/src/widgets/kpropertiesdialog.cpp:645:18: error: ‘class
KService’ has no member named ‘serviceId’
`QStringLiteral`
> kpropertiesdialog.h:251
> + */
> + void KPropertiesDialog::insertPluginAt(KPropertiesDialogPlugin *plugin,
> int index)
>
missing the semicolon
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23926
To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel,
pberestov, manueljlin, iasensio, Orage, fprice, LeGast00n, cblack, konkinartem,
ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde,
IohannesPetros, Codezela, feverfew, trickyricky26, michaelh, crozbo, spoorun,
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp,
mikesomov, aaronhoneycutt, mbohlender
