dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
The new code structure screams for killing the bool and just extracting the code (all of slotReparseSlaveConfiguration) to a different method, called directly from emitReparseSlaveConfiguration(). Accepting if you want to move on, but it would really be refactor that way. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28647 To: marten, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns