ngraham added a comment.
I have concerns about this. The button has no tooltip so it's not obvious what will happen when clicked on. It should at least say "Revert to default setting" in a tooltip, and preferably even the name or text of the default setting that will be reverted to. Also, we now have a new inconsistency in that a small fraction of System Settings KCMs and app settings windows will display these indicators, but not others. Finally clicking on the revert button in Spectacle's settings page causes a segfault for me: P590 Spectacle crash backtrace <https://phabricator.kde.org/P590> REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
