ahmadsamir added inline comments.

INLINE COMMENTS

> bruns wrote in fakeopticaldisc.cpp:43
> These four lines can be written as
> `content |= map.value(type, Solid::OpticalDisc::ContentType(0));`

Nice. :)

I think Solid::OpticalDisc::NoContent is more readable.

REPOSITORY
  R245 Solid

BRANCH
  l-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29138

To: ahmadsamir, #frameworks, dfaure, apol, meven
Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

Reply via email to