bruns added inline comments. INLINE COMMENTS
> ahmadsamir wrote in fakeopticaldisc.cpp:43 > It doesn't make the code more readable; and using QMap::constFind() while > iterating is more recognizable/widely-used. You are contradicting yourself. You use value() for content, but for supportedMedia it is a bad idea? Also, `supportedMedia |= 0` is obviously a noop, while for any named flag one has to lookup the flag value. REPOSITORY R245 Solid BRANCH l-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D29138 To: ahmadsamir, #frameworks, dfaure, apol, meven Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham
