alex added inline comments. INLINE COMMENTS
> itemsmodel.cpp:71 > + bool duplicate{false}; > + for (const EntryInternal& existingEntry : m_entries) { > + if (existingEntry == entry) { Use qAsConst(m_entries) and space before & not after :-) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29447 To: leinir, #knewstuff, #plasma, bugseforuns, ngraham, #frameworks Cc: alex, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot, ngraham, bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart