leinir added inline comments.

INLINE COMMENTS

> alex wrote in itemsmodel.cpp:71
> On second thought why not just use:
> `bool duplicate =  m_entries.contains(entry);`

Hmm... i do wonder slight of the cost of that, but also... much simpler code, 
so... basically can just go

  if (!m_entries.contains(entry)) {

below, rather than this more elaborate version.

> alex wrote in itemsmodel.cpp:71
> Use qAsConst(m_entries) and space before & not after :-)

Quite, thank you :)

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-show-only-updates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29447

To: leinir, #knewstuff, #plasma, bugseforuns, ngraham, #frameworks
Cc: alex, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot, ngraham, bruns, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

Reply via email to