meven added inline comments.

INLINE COMMENTS

> alex wrote in kpluginselector.cpp:855
> You could add a field to the KCModule class (thats where you ultimately want 
> to access the fileName).
> But then the downside is that you don't have them as a constructor argument.

moduleInfo is part of the ctor here, so the fileName is already available 
indirectly.
A good thing would be to avoid having an option for such a niche usage although 
legitimate.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik, mart
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

Reply via email to