----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118490/#review59066 -----------------------------------------------------------
Ship it! The actual changes are sensible, hence the shipit, but see also the comments below that you may want to address. src/mdnsd-servicetypebrowser.cpp <https://git.reviewboard.kde.org/r/118490/#comment41112> Interesting... any idea which monday? src/servicetypebrowser.h <https://git.reviewboard.kde.org/r/118490/#comment41113> Since when? src/servicetypebrowser.h <https://git.reviewboard.kde.org/r/118490/#comment41114> It looks like the mdnsd backend even just returns false, so this is not even reliable. With that in mind, I'd be tempted to make it an inline method that just always returns false. - Alex Merry On June 3, 2014, 6:59 a.m., Matthew Dawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118490/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 6:59 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdnssd > > > Description > ------- > > Change all occurrences of KDE_NO_DEPRECATED to an appropriate define. > > Inline with the new defines used by Frameworks, remove the usage of the > KDE_NO_DEPRECATED define. > > > Diffs > ----- > > src/avahi-servicetypebrowser.cpp b3c14f84367d5093a6cee5ef3f684edc201a3f96 > src/dummy-servicetypebrowser.cpp 39a4b6b660bb47b68b5721535994487dbe2abbf6 > src/mdnsd-servicetypebrowser.cpp d16dd1fa1c692cd20e21f1a7d5471ac7956469b3 > src/servicetypebrowser.h 3cd10e36bf089e088e8a48bb0cf73daa4fb859c5 > > Diff: https://git.reviewboard.kde.org/r/118490/diff/ > > > Testing > ------- > > Code still compiles. > > > Thanks, > > Matthew Dawson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
