----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118490/#review59299 -----------------------------------------------------------
Ship it! Ship It! - Alex Merry On June 5, 2014, 3:56 a.m., Matthew Dawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118490/ > ----------------------------------------------------------- > > (Updated June 5, 2014, 3:56 a.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kdnssd > > > Description > ------- > > Properly mark ServiceBrowser::isRunning as deprecated. > > Fix the @deprecated notation to be correct. Also, make the function a simple > inline function that always returns false. This should cause minimal breakage > while avoiding overhead from the function. > > > Diffs > ----- > > src/mdnsd-servicetypebrowser.cpp d16dd1fa1c692cd20e21f1a7d5471ac7956469b3 > src/dummy-servicetypebrowser.cpp 39a4b6b660bb47b68b5721535994487dbe2abbf6 > src/avahi-servicetypebrowser.cpp b3c14f84367d5093a6cee5ef3f684edc201a3f96 > src/servicetypebrowser.h 3cd10e36bf089e088e8a48bb0cf73daa4fb859c5 > > Diff: https://git.reviewboard.kde.org/r/118490/diff/ > > > Testing > ------- > > Code still compiles. > > > Thanks, > > Matthew Dawson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel