----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120728/#review68952 -----------------------------------------------------------
You can rename it AFAIU. Given that no external project has seen the header file, nobody is linking against it (if they don't copy the header over, which is not supported, of course). - Aleix Pol Gonzalez On Oct. 22, 2014, 5:33 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120728/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 5:33 p.m.) > > > Review request for KDE Frameworks. > > > Repository: knotifications > > > Description > ------- > > ...to allow custom KNotification plugins. This class is being exported since > ever, but the public header was missing. > > Also, I'd like to rename this class to KNotificationPlugin rather than > KNotifyPlugin as there is no KNotify anymore, but renaming already exported > class is not allowed in frameworks as that would break BC, right? > > > Diffs > ----- > > src/CMakeLists.txt 5b109c8 > > Diff: https://git.reviewboard.kde.org/r/120728/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
