> On Říj. 23, 2014, 1:12 dop., Aleix Pol Gonzalez wrote: > > You can rename it AFAIU. > > Given that no external project has seen the header file, nobody is linking > > against it (if they don't copy the header over, which is not supported, of > > course). > > Martin Klapetek wrote: > My thinking is that rename = remove an exported class and add a new > exported class; and the first one breaks BC. Is this not the case? > > However, my knowledge in this matter is quite basic.
You can rename it, it hasn't been possible to directly include it until now, so it should be safe - Lukáš ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120728/#review68952 ----------------------------------------------------------- On Říj. 22, 2014, 7:33 odp., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120728/ > ----------------------------------------------------------- > > (Updated Říj. 22, 2014, 7:33 odp.) > > > Review request for KDE Frameworks. > > > Repository: knotifications > > > Description > ------- > > ...to allow custom KNotification plugins. This class is being exported since > ever, but the public header was missing. > > Also, I'd like to rename this class to KNotificationPlugin rather than > KNotifyPlugin as there is no KNotify anymore, but renaming already exported > class is not allowed in frameworks as that would break BC, right? > > > Diffs > ----- > > src/CMakeLists.txt 5b109c8 > > Diff: https://git.reviewboard.kde.org/r/120728/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
