----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/#review69967 -----------------------------------------------------------
Ship it! Finally! - Kevin Funk On Nov. 6, 2014, 1:05 a.m., Milian Wolff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121007/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 1:05 a.m.) > > > Review request for KDE Frameworks. > > > Repository: solid > > > Description > ------- > > "No such signal org::freedesktop::UPower::DeviceAdded(...)" > > The signature change can be detected at runtime using Qt's QMetaObject > introspection mechanism. That prevents us from emitting the two > pesky warnings at runtime, polluting our konsoles. > > Google is full of that warning, and there is also: > https://bugzilla.redhat.com/show_bug.cgi?id=1056769 > > > Diffs > ----- > > src/solid/devices/backends/upower/upowermanager.cpp > 53c858093a1c439f0faca0c956a51199f4e882e4 > > Diff: https://git.reviewboard.kde.org/r/121007/diff/ > > > Testing > ------- > > warning gone! > > > Thanks, > > Milian Wolff > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
