> On Lis. 7, 2014, 1:19 odp., David Faure wrote: > > Thank you very much for looking into this. I talked to Lukas Tinkl about it > > when we met, though, and IIRC he said that it couldn't be fixed that simply > > (because of the dbus signal magic)? I'm not sure though. Did you check that > > indexOfSignal("DeviceAdded(QDBusObjectPath)") works? > > (simpler than downgrading UPower). > > Milian Wolff wrote: > Yes, I did check that. You can also iterate over the QMetaObject's > QMetaProperties and print their names. I did see > `DeviceAdded(QDBusObjectPath)` and friends in there. I assume with an older > UPower, I'd see `DeviceAdded(QString)` etc. > > Can someone with an older UPower test this and make sure? > > Milian Wolff wrote: > Put differently: @Lukáš Tinkl: What did you try before, and why did you > think it would fail this way?
I didn't say it would fail, I just didn't see this as an option. :) Anyway, I can confirm that I'm seeing DeviceAdded(QString) on my system with an older upower. - Lukáš ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/#review69983 ----------------------------------------------------------- On Lis. 7, 2014, 2:33 odp., Milian Wolff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121007/ > ----------------------------------------------------------- > > (Updated Lis. 7, 2014, 2:33 odp.) > > > Review request for KDE Frameworks, Àlex Fiestas, David Faure, and Lukáš Tinkl. > > > Bugs: 339014 > https://bugs.kde.org/show_bug.cgi?id=339014 > > > Repository: solid > > > Description > ------- > > "No such signal org::freedesktop::UPower::DeviceAdded(...)" > > The signature change can be detected at runtime using Qt's QMetaObject > introspection mechanism. That prevents us from emitting the two > pesky warnings at runtime, polluting our konsoles. > > Google is full of that warning, and there is also: > https://bugzilla.redhat.com/show_bug.cgi?id=1056769 > > > Diffs > ----- > > src/solid/devices/backends/upower/upowermanager.cpp > 53c858093a1c439f0faca0c956a51199f4e882e4 > > Diff: https://git.reviewboard.kde.org/r/121007/diff/ > > > Testing > ------- > > warning gone! > > > Thanks, > > Milian Wolff > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel