----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123872/#review80698 -----------------------------------------------------------
LGTM in general, but could you please add/update a unit test to test all the possible cominbations of the translation? - Matthew Dawson On May 21, 2015, 11:21 a.m., Chusslove Illich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123872/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 11:21 a.m.) > > > Review request for KDE Frameworks, Alexander Potashev and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > When using Ki18n as the translation system, library .kcfg files also need to > specify the translation domain. This is analogous to the TRANSLATION_DOMAIN > define in C++ code, and translationDomain attribute in .rc files. > > > Diffs > ----- > > src/kconfig_compiler/kconfig_compiler.cpp 7160bb5 > > Diff: https://git.reviewboard.kde.org/r/123872/diff/ > > > Testing > ------- > > Compiles. > > > Thanks, > > Chusslove Illich > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel