----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81500 -----------------------------------------------------------
+1 - David Edmundson On June 15, 2015, 5:59 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124104/ > ----------------------------------------------------------- > > (Updated June 15, 2015, 5:59 p.m.) > > > Review request for Build System, KDE Frameworks, Matthew Dawson, and Harald > Sitter. > > > Repository: kconfig > > > Description > ------- > > Separates the tooling that is supposed to be used at run-time so that we can > specify which to use explicitly. > > Ideally this would be done automagically, for now we'll have to specify > -DKF5ConfigCompiler_DIR=... > > Additionally, we should make kconfig_compiler co-installable by putting it in > libexec, but I'd prefer to do that in a future patch. This same process > should also happen on other frameworks. > > > Diffs > ----- > > CMakeLists.txt f510e3e > KF5ConfigConfig.cmake.in b4e5f56 > src/kconfig_compiler/CMakeLists.txt ec4a733 > > Diff: https://git.reviewboard.kde.org/r/124104/diff/ > > > Testing > ------- > > Works as expected on my debian chroot environment. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel