> On June 15, 2015, 11:12 p.m., Matthew Dawson wrote: > > src/kconfig_compiler/CMakeLists.txt, line 16 > > <https://git.reviewboard.kde.org/r/124104/diff/1/?file=380232#file380232line16> > > > > Does this mean a cross-compiled KConfig won't be built right for > > development on the target? If this happens regardless, is the cross > > compiling still possible? > > > > My CMake foo is weak, so if no one knows an alternative, I'm fine. I'd > > just prefer KConfig to work on the target for development too. > > Aleix Pol Gonzalez wrote: > Well, the idea is that if you're cross-compiling, the generated > executable won't work on the host architecture, by definition. > > In case it's needed, we could import an actual > KF5ConfigCompilerConfig.cmake from the host architecture. In this case it > doesn't really make sense though.
What I meant is that a cross-compilied KConfig would be built in such a way that transporting it to its native environment would allow it to be used as a complete development environment (assuming all the development related files were copied). With this change, that doesn't work anymore. It's a corner case, and if it breaks this otherwise fine RR, I'm not worried. But it would be nice to have. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124104/#review81501 ----------------------------------------------------------- On June 17, 2015, 9:19 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124104/ > ----------------------------------------------------------- > > (Updated June 17, 2015, 9:19 p.m.) > > > Review request for Build System, KDE Frameworks, Matthew Dawson, and Harald > Sitter. > > > Repository: kconfig > > > Description > ------- > > Separates the tooling that is supposed to be used at run-time so that we can > specify which to use explicitly. > > Ideally this would be done automagically, for now we'll have to specify > -DKF5ConfigCompiler_DIR=... > > Additionally, we should make kconfig_compiler co-installable by putting it in > libexec, but I'd prefer to do that in a future patch. This same process > should also happen on other frameworks. > > > Diffs > ----- > > CMakeLists.txt f510e3e > KF5ConfigConfig.cmake.in b4e5f56 > src/kconfig_compiler/CMakeLists.txt ec4a733 > > Diff: https://git.reviewboard.kde.org/r/124104/diff/ > > > Testing > ------- > > Works as expected on my debian chroot environment. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel