> On Nov. 19, 2015, 6:03 a.m., Vishesh Handa wrote: > > I'm a little hesitant about this, but ship it. > > > > A couple of things though - > > 1. Dolphin should probably not be sending Baloo so many requests if Baloo > > is disabled. Perhaps we should fix this in Dolphin. > > 2. This patch is mostly only for the Baloo::File class which causes the db > > to be opened and closed for each operation. It's expensive, but the main > > use case that I focussed on was searching. Over there the db is only opened > > once per application.
I concur, the errant calls are being made by Baloo-Widgets and we should probably fix Baloo-Widgets to not go through the hassle of invoking lower-level baloo functions if it's disabled. I'll look into it - is there a simple API in Baloo which I can check to see if indexing is disabled? Can I use Baloo::IndexerConfig::fileIndexingEnabled() from Baloo-Widgets to do this check? - Boudhayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126105/#review88554 ----------------------------------------------------------- On Nov. 19, 2015, 1:10 a.m., Boudhayan Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126105/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 1:10 a.m.) > > > Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Add a check in Baloo::Database::open() to return false if we're opening the > database in ReadOnly mode and the database doesn't exist. This fixes a crash > in Dolphin when Baloo isn't running. > > This isn't the entire fix - one will also have to remove > ~/.local/share/baloo/index to not crash anymore; this patch prevents the file > from being recreated everytime Baloo::Database::open() is run, and re-causing > the crash. > > > Diffs > ----- > > src/engine/database.cpp 4f0579f > > Diff: https://git.reviewboard.kde.org/r/126105/diff/ > > > Testing > ------- > > Builds, runs, doesn't crash anymore, the works. > > > Thanks, > > Boudhayan Gupta > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel