> On Nov. 19, 2015, 10:35 a.m., Sune Vuorela wrote: > > without actualy knowing the code in question, a brief look over gives me > > the impression that the error handling could be improved and that would > > make this patch not needed.
The assumption here is that if (rc != 0) in normal operation the errors are serious enough to warrant crashing the process, not handling it gracefully. Granted, I've just discovered one case where this isn't true, but that's when indexing is disabled and the db file shouldn't exist, so I've added a special check for that. Also, that patch prevents an empty index from being created even when indexing is disabled, which is correct behaviour. - Boudhayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126105/#review88556 ----------------------------------------------------------- On Nov. 19, 2015, 1:10 a.m., Boudhayan Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126105/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 1:10 a.m.) > > > Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Add a check in Baloo::Database::open() to return false if we're opening the > database in ReadOnly mode and the database doesn't exist. This fixes a crash > in Dolphin when Baloo isn't running. > > This isn't the entire fix - one will also have to remove > ~/.local/share/baloo/index to not crash anymore; this patch prevents the file > from being recreated everytime Baloo::Database::open() is run, and re-causing > the crash. > > > Diffs > ----- > > src/engine/database.cpp 4f0579f > > Diff: https://git.reviewboard.kde.org/r/126105/diff/ > > > Testing > ------- > > Builds, runs, doesn't crash anymore, the works. > > > Thanks, > > Boudhayan Gupta > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
