----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/#review89939 -----------------------------------------------------------
The patch seems straight-forward. I can not find the reference that QRegularExpression is thread-safe (the most I see is 'all functions in this class are reentrant which is stated for QRegExp as well). The QRegExp vs QRegularExpression situation is quite confusing, but the later should be preferred in Qt 5.x - it is faster if nothing else. - Ivan Čukić On Dec. 22, 2015, 4:52 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126474/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 4:52 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > A static QRegExp was used but it is not thread safe. QRegularExpression > seems to be. > > BUG: 352356 > > > Diffs > ----- > > src/urifilters/shorturi/kshorturifilter.cpp > 1af4768b7b5ab9d1f5af52f17170d466d854b9bb > > Diff: https://git.reviewboard.kde.org/r/126474/diff/ > > > Testing > ------- > > I ran the autotests which includes urifilter and I've run krunner which uses > it extensively. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
