> On Jan. 1, 2016, 5:15 p.m., David Faure wrote: > > src/urifilters/shorturi/kshorturifilter.cpp, line 58 > > <https://git.reviewboard.kde.org/r/126474/diff/2/?file=426362#file426362line58> > > > > "despite" sounds like the api docs say that it's not thread safe. > > AFAICS the docs don't say anything either way. I agree that one shouldn't > > assume thread-safety unless explicitly documented, but I think it's just an > > omission in the doc, the whole point of the QRegularExpression API is > > thread safety.
I talked to Giuseppe, he'll update the docu to mention thread safety. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/#review90403 ----------------------------------------------------------- On Dec. 28, 2015, 2:20 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126474/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2015, 2:20 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > A static QRegExp was used but it is not thread safe. QRegularExpression > seems to be. > > BUG: 352356 > > > Diffs > ----- > > src/urifilters/shorturi/kshorturifilter.cpp > 6002ec6925c0acdd20a053f98baca46863f69fa6 > > Diff: https://git.reviewboard.kde.org/r/126474/diff/ > > > Testing > ------- > > I ran the autotests which includes urifilter and I've run krunner which uses > it extensively. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel