----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/ -----------------------------------------------------------
(Updated Dec. 27, 2015, 5:14 p.m.) Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David Faure, and Luigi Toscano. Changes ------- I have one more element now in place: protocoltojson converts the translated stuff in the same format as desktoptojson (the helper from KPluginMetaData can be used to read it). Still to do: to add the helper to do the json => po => json conversion. Is this change ok that way? I would first submit this and open a new request for the missing parts and and extra one for the conversion of the existing .protocol files. Repository: kio Description ------- Convert all io slave .protocol data to json and embed it. Allows easier deployment of the slaves. Diffs (updated) ----- src/core/kprotocolinfo.cpp 7bfb9ad src/protocoltojson/main.cpp 05b9364 Diff: https://git.reviewboard.kde.org/r/125869/diff/ Testing ------- Tests still work (one needed patching, as the exec line contains now the full path). Correction: Somehow the ./autotests/jobtest test is unstable for me here, sometimes it works, sometimes not :/ but even without this change. Thanks, Christoph Cullmann
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel