----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/#review91279 -----------------------------------------------------------
Fix it, then Ship it! src/protocoltojson/main.cpp (line 137) <https://git.reviewboard.kde.org/r/125869/#comment62406> looks unused to me src/protocoltojson/main.cpp (line 138) <https://git.reviewboard.kde.org/r/125869/#comment62407> const QString &key src/protocoltojson/main.cpp (line 141) <https://git.reviewboard.kde.org/r/125869/#comment62410> protocolData.insert(key, ...) would be slightly faster (see Effective C++) src/protocoltojson/main.cpp (line 149) <https://git.reviewboard.kde.org/r/125869/#comment62409> Move it outside the outer loop, so it gets constructed only once. src/protocoltojson/main.cpp (line 159) <https://git.reviewboard.kde.org/r/125869/#comment62408> const QString & - David Faure On Jan. 3, 2016, 6:19 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125869/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2016, 6:19 p.m.) > > > Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David > Faure, and Luigi Toscano. > > > Repository: kio > > > Description > ------- > > Allows protocoltojson & kio to handle translated json ExtraNames > > > Diffs > ----- > > src/core/kprotocolinfo.cpp 7bfb9ad > src/protocoltojson/main.cpp 05b9364 > > Diff: https://git.reviewboard.kde.org/r/125869/diff/ > > > Testing > ------- > > make && make test still OK. > > > File Attachments > ---------------- > > trash.json > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel