> On Jan. 21, 2016, 11:10 a.m., Sebastian Kügler wrote: > > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 395 > > <https://git.reviewboard.kde.org/r/126804/diff/1/?file=434496#file434496line395> > > > > DPI-dependent, could be shared with the above > > David Rosca wrote: > Multiply with `window()->devicePixelRatio()` ?
Yup, that'll work. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126804/#review91400 ----------------------------------------------------------- On Jan. 18, 2016, 9 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126804/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 9 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > ------- > > Implement grabbing image of delegate with QQuickItem::grabToImage. > > > Diffs > ----- > > src/qmlcontrols/draganddrop/DeclarativeDragArea.h 32092ab > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp ee78ff9 > > Diff: https://git.reviewboard.kde.org/r/126804/diff/ > > > Testing > ------- > > QQuickItem::grabToImage is async, not sure how safe is to delay the start of > drag. It seems to work without any issues though. > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel