> On Jan. 21, 2016, 2:47 p.m., Sebastian Kügler wrote: > > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 402 > > <https://git.reviewboard.kde.org/r/126804/diff/2/?file=435071#file435071line402> > > > > With many urls in the mimedata, this could produce a very wide pixmap. > > I suggest either limiting the width by eliding, or doign multiple rows. > > This can be done in a subsequent patch. For now, it'd be good enough IMO to > > break out of the loop after like 8 icons.
Ok, I'll limit it to 4 urls, so there will be at max 6 icons (in case the mimeData has text, html and urls). - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126804/#review91417 ----------------------------------------------------------- On Jan. 21, 2016, 2:26 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126804/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2016, 2:26 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > ------- > > Implement grabbing image of delegate with QQuickItem::grabToImage. > > > Diffs > ----- > > src/qmlcontrols/draganddrop/DeclarativeDragArea.h 32092ab > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp ee78ff9 > > Diff: https://git.reviewboard.kde.org/r/126804/diff/ > > > Testing > ------- > > QQuickItem::grabToImage is async, not sure how safe is to delay the start of > drag. It seems to work without any issues though. > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
