> On Feb. 10, 2016, 11:14 p.m., Albert Astals Cid wrote: > > src/lib/kcoreaddons.h, line 29 > > <https://git.reviewboard.kde.org/r/127031/diff/1/?file=443954#file443954line29> > > > > Documntation is missing > > > > Also "technically" one could mix and max versions even if we don't do > > it nor support it, but maybe we could call it just version() so it would be > > KCoreAddons::version() which give us a clear indication that in a world of > > mix & match this may b different frm KXMLGUI::version() (if it existed) > > > > Or am i overthinking this? > > David Edmundson wrote: > I did consider putting it in ECM so it was in every module, but it seemed > over complex especially as some frameworks have multiple libs. > Also I can't imagine a situation where you'd really want to show more > than one text label. > > I'll do the rename though, that's a good compromise.
Nope, we can't have a different version of KCoreAddons and KXMLGUI. (although I also prefer `::version()`). +1 for docs. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127031/#review92245 ----------------------------------------------------------- On Feb. 11, 2016, 1:53 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127031/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 1:53 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > Adds a method similar to qVersion() that returns a string of the > frameworks version being run. This differs from the header file which > can only provide the version this app is compiled against. > > The intended usage is in drkonqi system information. > > > Diffs > ----- > > src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 > src/lib/kcoreaddons.h PRE-CREATION > src/lib/kcoreaddons.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127031/diff/ > > > Testing > ------- > > See https://git.reviewboard.kde.org/r/127032/ > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
