----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127031/#review92298 -----------------------------------------------------------
src/lib/kcoreaddons.h (line 33) <https://git.reviewboard.kde.org/r/127031/#comment62964> The docu is missing a @since 5.20 Also, while at it, I wonder if we should have ints for major, minor, and patch, to be able to test this in code, not just print it out (I guess mostly for workarounds / adjusting for behaviour changes). - David Faure On Feb. 11, 2016, 12:53 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127031/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 12:53 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > Adds a method similar to qVersion() that returns a string of the > frameworks version being run. This differs from the header file which > can only provide the version this app is compiled against. > > The intended usage is in drkonqi system information. > > > Diffs > ----- > > src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 > src/lib/kcoreaddons.h PRE-CREATION > src/lib/kcoreaddons.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127031/diff/ > > > Testing > ------- > > See https://git.reviewboard.kde.org/r/127032/ > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel